New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optional attr min and max validation generation #91

Merged

Peefy merged 1 commit into kcl-lang:main from Peefy:fix-optional-attr-min-and-max-validation-gen

Jun 20, 2024

Contributor

Peefy commented Jun 20, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

N
Y

fix kcl-lang/kcl#1420

fix: optional attr min and max validation generation


          fix: optional attr min and max validation generation

70bd1d4

Signed-off-by: peefy <xpf6677@163.com>

Peefy mentioned this pull request

Conditional checks on imported resources kcl-lang/kcl#1420

Closed

zong-zhe approved these changes

View reviewed changes

zong-zhe left a comment

LGTM

Collaborator

coveralls commented Jun 20, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9591095901

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.1%) to 67.642%

Totals
Change from base Build 8352877304:	1.1%
Covered Lines:	2149
Relevant Lines:	3177

💛 - Coveralls

Peefy merged commit d8d845c into kcl-lang:main

5 checks passed

Peefy deleted the fix-optional-attr-min-and-max-validation-gen branch

June 20, 2024 03:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet