Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parser error messages into the result of api ListVariables #1316

Merged
merged 3 commits into from
May 15, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added enhancement New feature or request api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels May 15, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone May 15, 2024
@zong-zhe zong-zhe requested a review from Peefy May 15, 2024 06:41
@zong-zhe zong-zhe self-assigned this May 15, 2024
kclvm/spec/gpyrpc/gpyrpc.proto Outdated Show resolved Hide resolved
kclvm/query/src/selector.rs Outdated Show resolved Hide resolved
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Pull Request Test Coverage Report for Build 9091385589

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 71 of 71 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.06%

Totals Coverage Status
Change from base Build 9091056675: 0.03%
Covered Lines: 53591
Relevant Lines: 75417

💛 - Coveralls

@Peefy Peefy merged commit 4ebbb55 into kcl-lang:main May 15, 2024
8 of 10 checks passed
@zong-zhe zong-zhe deleted the add-api-err branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants