Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unwrap() in advanced_resolver. #1318

Merged
merged 2 commits into from
May 15, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented May 15, 2024

Change AdvancedResolver::resolve_program() return type from Option to Result<Option>
Remove unwrap() in resolve_program()

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver
tools/src/LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

remove unwrap() in advanced_resolver.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…on return type from Option<Symbol> to Result<Option<Symbol>>

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the remove_unwrap_in_advanced_resolver branch from b8d7f98 to 17bdea8 Compare May 15, 2024 09:34
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

Signed-off-by: he1pa <18012015693@163.com>
@Peefy Peefy merged commit 9e3fc86 into kcl-lang:main May 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants