Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance doc parse and add lambda doc hover #1342

Merged
merged 1 commit into from
May 21, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 21, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #1339

  • feat: enhance doc parse and add lambda doc hover

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/evaluator/src/node.rs
  • kclvm/parser/src/parser/module.rs
  • kclvm/parser/src/parser/stmt.rs
  • kclvm/parser/src/session/mod.rs
  • kclvm/sema/src/resolver/doc.rs
  • kclvm/sema/src/resolver/doc.rs
  • kclvm/sema/src/resolver/global.rs
  • kclvm/sema/src/resolver/node.rs
  • kclvm/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/tools/src/LSP/src/hover.rs
  • test/grammar/scalar/string/string_0/main.k

@Peefy Peefy requested review from He1pa and zong-zhe May 21, 2024 08:08
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy force-pushed the enhance-doc-parse-and-hover branch from 2b30af5 to 9be4f1f Compare May 21, 2024 08:46
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the enhance-doc-parse-and-hover branch from 9be4f1f to 5974710 Compare May 21, 2024 09:30
@Peefy Peefy merged commit 9e1ff13 into kcl-lang:main May 21, 2024
7 of 10 checks passed
@Peefy Peefy deleted the enhance-doc-parse-and-hover branch May 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the first string literal in KCL is compiled into "{}"
3 participants