Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: treat kcl.mod file as a compile unit #1348

Merged
merged 1 commit into from
May 22, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 22, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: treat kcl.mod file as a compile unit

2. What is the scope of this PR (e.g. component or file name):

  • feat: treat kcl.mod file as a compile unit
  • kclvm/config/src/modfile.rs
  • kclvm/config/src/vfs.rs
  • kclvm/driver/src/lib.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/config/src/testdata/kcl.mod

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9188605121

Details

  • 81 of 102 (79.41%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 71.082%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/config/src/modfile.rs 51 57 89.47%
kclvm/driver/src/lib.rs 24 39 61.54%
Files with Coverage Reduction New Missed Lines %
kclvm/config/src/modfile.rs 1 93.67%
Totals Coverage Status
Change from base Build 9177105510: -0.009%
Covered Lines: 53860
Relevant Lines: 75772

💛 - Coveralls

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the feat-mod-file-compile-unit branch from 48e0ea0 to 857b90a Compare May 22, 2024 09:13
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 017610b into kcl-lang:main May 22, 2024
10 checks passed
@Peefy Peefy deleted the feat-mod-file-compile-unit branch May 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants