feat: api list_variables supports get variables from multi-files #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zongz <zongzhe1024@163.com>
zong-zhe
added
the
api
Peefy
reviewed
Jun 3, 2024
kclvm/query/src/selector.rs
Outdated
| @@ -461,26 +462,25 @@ impl Variable { | |||
|
|
|||
| /// list_options provides users with the ability to parse kcl program and get all option | |||
| /// calling information. | |||
| pub fn list_variables(file: String, specs: Vec<String>) -> Result<ListVariablesResult> { | |||
| pub fn list_variables(files: Vec<&str>, specs: Vec<String>) -> Result<ListVariablesResult> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn list_variables(files: Vec<&str>, specs: Vec<String>) -> Result<ListVariablesResult> { | |
| pub fn list_variables(files: Vec<String>, specs: Vec<String>) -> Result<ListVariablesResult> { |
kclvm/query/src/selector.rs
Outdated
| let mut selector = Selector::new(specs)?; | ||
| let parse_result = parse_file(&file, None)?; | ||
| // let parse_result = parse_file(&file, None)?; |
| let specs = args.specs.clone(); | ||
|
|
||
| let select_res = list_variables(k_file, specs)?; | ||
| let select_res = list_variables(k_files, specs)?; |
There was a problem hiding this comment.
Just use &[String] or Vec<String> instead of Vec<&str>
Signed-off-by: zongz <zongzhe1024@163.com>
Pull Request Test Coverage Report for Build 9347790842Details
💛 - Coveralls |
Signed-off-by: zongz <zongzhe1024@163.com>
shruti2522
added a commit
to shruti2522/kcl
that referenced
this pull request
Jun 3, 2024
Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add function symbol kind to lsp Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update function symbol def Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix ci Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix ci Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add tests to sema_token Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add get_function_symbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> highlight for func call Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> modify walk_call_expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update namer for func_name Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: distinguish highlight for func symbol and normal var symbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update alloc_function_symbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> function symbol for builtin functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update function symbol def Signed-off-by: shruti2522 <shruti.apc01@gmail.com> delete test.log Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove func symbol from walk_call_expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update walk_call_expr for namer Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update sema test Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add function symbol kind in global state Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update hover to handle func symbolkind Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add condition for symbolkind in hover Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove print statements Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update loader snapshots Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix advanced resolver Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update assign stmt for lambda expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update resolve_names for identifier_expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update semantic tokens with function type Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: api list_variables supports get variables from multi-files (kcl-lang#1389) * feat: api list_variables supports get variables from multi-files Signed-off-by: zongz <zongzhe1024@163.com> * fix: fix CR comments Signed-off-by: zongz <zongzhe1024@163.com> * fix: fix test cases Signed-off-by: zongz <zongzhe1024@163.com> --------- Signed-off-by: zongz <zongzhe1024@163.com> feat: advance resolver incremental compile (kcl-lang#1209) feat: advanced resolver incremental compile. 1. Namer and Advanced Resolver support incremental compilation, clear cache by pkg and only update new pkg 2. Add gs cache in lsp state 3. Namer and Advanced Resolver modify gs in place(&mut) to reduce clone Signed-off-by: he1pa <18012015693@163.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> resolve conflicts Signed-off-by: shruti2522 <shruti.apc01@gmail.com> resolve conflicts Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> resolve conflicts Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove duplicate code Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove repititions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Peefy
pushed a commit
that referenced
this pull request
Jun 3, 2024
…#1386) * feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add function symbol kind to lsp Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update function symbol def Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix ci Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix ci Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add tests to sema_token Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add get_function_symbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> highlight for func call Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> modify walk_call_expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update namer for func_name Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: distinguish highlight for func symbol and normal var symbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update alloc_function_symbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> function symbol for builtin functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update function symbol def Signed-off-by: shruti2522 <shruti.apc01@gmail.com> delete test.log Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove func symbol from walk_call_expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update walk_call_expr for namer Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update sema test Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add function symbol kind in global state Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update hover to handle func symbolkind Signed-off-by: shruti2522 <shruti.apc01@gmail.com> add condition for symbolkind in hover Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove print statements Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update loader snapshots Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fix advanced resolver Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update assign stmt for lambda expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update resolve_names for identifier_expr Signed-off-by: shruti2522 <shruti.apc01@gmail.com> update semantic tokens with function type Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: api list_variables supports get variables from multi-files (#1389) * feat: api list_variables supports get variables from multi-files Signed-off-by: zongz <zongzhe1024@163.com> * fix: fix CR comments Signed-off-by: zongz <zongzhe1024@163.com> * fix: fix test cases Signed-off-by: zongz <zongzhe1024@163.com> --------- Signed-off-by: zongz <zongzhe1024@163.com> feat: advance resolver incremental compile (#1209) feat: advanced resolver incremental compile. 1. Namer and Advanced Resolver support incremental compilation, clear cache by pkg and only update new pkg 2. Add gs cache in lsp state 3. Namer and Advanced Resolver modify gs in place(&mut) to reduce clone Signed-off-by: he1pa <18012015693@163.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> resolve conflicts Signed-off-by: shruti2522 <shruti.apc01@gmail.com> resolve conflicts Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> resolve conflicts Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove duplicate code Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove repititions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added FunctionSymbol Signed-off-by: shruti2522 <shruti.apc01@gmail.com> * remove unwanted changes in global_state Signed-off-by: shruti2522 <shruti.apc01@gmail.com> remove unwanted changes in global_state Signed-off-by: shruti2522 <shruti.apc01@gmail.com> * fmt check Signed-off-by: shruti2522 <shruti.apc01@gmail.com> --------- Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: