Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong long str interpolation location with special chars #1409

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: wrong long str interpolation location with special chars

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/parser/src/parser/stmt.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/parser/src/tests/error_recovery.rs
  • kclvm/parser/src/tests/snapshots/kclvm_parser__tests__error_recovery__joined_string_recovery_10.snap
  • kclvm/parser/src/tests/snapshots/kclvm_parser__tests__error_recovery__joined_string_recovery_11.snap
  • kclvm/parser/src/tests/snapshots/kclvm_parser__tests__error_recovery__joined_string_recovery_12.snap

@Peefy Peefy added bug Something isn't working parser Issues or PRs related to kcl parser labels Jun 12, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Jun 12, 2024
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 33629fd into kcl-lang:main Jun 12, 2024
8 of 11 checks passed
@Peefy Peefy deleted the fix-long-str-inter-loc-with-special-chars branch June 12, 2024 08:53
@coveralls
Copy link
Collaborator

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9479136684

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 32 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 71.11%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/state.rs 1 82.13%
Totals Coverage Status
Change from base Build 9477669222: 0.004%
Covered Lines: 55071
Relevant Lines: 77445

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants