Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type infer in assignstmt #1411

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: fix type infer in assignstmt #1411

merged 1 commit into from
Jun 19, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jun 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/scope.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

rename set_type_to_scope -> set_infer_type_to_scope
use annotation type as assign stmt target type if exist

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9511654935

Details

  • 20 of 30 (66.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 71.107%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/node.rs 1 2 50.0%
kclvm/sema/src/resolver/loop.rs 7 10 70.0%
kclvm/sema/src/resolver/scope.rs 12 18 66.67%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/ty/unify.rs 1 97.81%
Totals Coverage Status
Change from base Build 9479636378: -0.003%
Covered Lines: 55081
Relevant Lines: 77462

💛 - Coveralls

@Peefy Peefy merged commit edecd59 into kcl-lang:main Jun 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Do not upgrade type in the assign statement for the literal type
3 participants