Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting PROTOC environment variable #1414

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fix: allow setting PROTOC environment variable #1414

merged 3 commits into from
Jun 19, 2024

Conversation

MatisseB
Copy link
Contributor

@MatisseB MatisseB commented Jun 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1413

2. What is the scope of this PR (e.g. component or file name):

kclvm/third-party/prost-wkt/wkt-types/build.rs
kclvm/api/build.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

This fix ensures that if the PROTOC environment variable is already set, it will be used; otherwise, it defaults to using the protoc_bin_vendored binaries. This improves the flexibility of the protocol buffer compiler setup.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

No tests seams to be required for this change as the integration is pretty straightforward.


I have read the CLA Document and I hereby sign the CLA

Copy link

github-actions bot commented Jun 15, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@Peefy Peefy merged commit 71a192e into kcl-lang:main Jun 19, 2024
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Support configurable PROTOC environment variable with fallback to vendored binaries
2 participants