-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for if. #1416
Add test case for if. #1416
Conversation
e83babe
to
15b1c43
Compare
Hello @liangyuanpeng Fixed in #1418 and #1423. You can rebase the main branch, and update the test case to _nodes=[]
if True:
print("Condition: True") # Use the right YAML form
elif False:
_nodes+=[]
nodes=_nodes |
Hi @Peefy Thanks for your quickly reply and work for it! rebased main. I have not get that why it's need to use the yaml data, In the real world, this is how people actually use it. Is this due to test case limitations? -- print("Condition is true.")
++ print("Condition: True") # Use the right YAML form |
Hello @liangyuanpeng At present, KCL's e2e testing only recognizes legitimate YAML data, which is different from real-world cases. |
Thank you for your clarification, updated |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! LGTM!
Thanks for the contribution!
Pull Request Test Coverage Report for Build 9594724261Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9594724261Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Releated #1410
Add a new test case for if.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: