Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix advanced_resolver schema def scope. reomve duplicate scopes #1480

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1477

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver
kclvm/sema/src/core/scope.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix advanced_resolver schema def scope. reomve duplicate scopes

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy
Copy link
Contributor

Peefy commented Jul 8, 2024

Cloud you please add a unit test case in #1477

Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Jul 8, 2024

complete_with_version_test failed.

Signed-off-by: he1pa <18012015693@163.com>
@Peefy Peefy merged commit 0f1ec1b into kcl-lang:main Jul 9, 2024
11 of 13 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9850198186

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 63 of 71 (88.73%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 71.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/advanced_resolver/mod.rs 59 67 88.06%
Totals Coverage Status
Change from base Build 9835611678: 0.02%
Covered Lines: 56628
Relevant Lines: 79316

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The loader will return the incorrect number of scopes when there is a schema present
3 participants