Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor find ref and rename #1500

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Refactor find ref and rename #1500

merged 2 commits into from
Aug 27, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 16, 2024

blocked by #1510

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs
kclvm/sema/src/core/symbol.rs
kclvm/tools/src/LSP/src/find_refs.rs
kclvm/tools/src/LSP/src/request.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/state.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/state.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the refactor_find_ref branch from f991a36 to 921224d Compare July 16, 2024 08:56
@He1pa He1pa force-pushed the refactor_find_ref branch from 518c26d to dd53318 Compare July 16, 2024 09:21
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Additional attention should be paid to whether APIs such as Rename, RenamdeCode, and FindRefs, as well as their test cases, have been fully passed without any breaks.

@Peefy
Copy link
Contributor

Peefy commented Jul 16, 2024

LGTM. Additional attention should be paid to whether APIs such as Rename, RenamdeCode, and FindRefs, as well as their test cases, have been fully passed without any breaks.

@Peefy Peefy changed the title Refactor find ref [WIP] Refactor find ref Jul 17, 2024
@He1pa He1pa marked this pull request as draft July 17, 2024 11:29
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the refactor_find_ref branch from dd53318 to 0a100f7 Compare August 27, 2024 13:49
@He1pa He1pa changed the title [WIP] Refactor find ref Refactor find ref and rename Aug 27, 2024
@He1pa He1pa marked this pull request as ready for review August 27, 2024 13:50
Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10579515428

Details

  • 188 of 239 (78.66%) changed or added relevant lines in 8 files are covered.
  • 26 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.2%) to 70.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/request.rs 18 20 90.0%
kclvm/tools/src/LSP/src/state.rs 5 7 71.43%
kclvm/tools/src/LSP/src/find_refs.rs 49 54 90.74%
kclvm/tools/src/LSP/src/util.rs 14 23 60.87%
kclvm/sema/src/core/symbol.rs 73 106 68.87%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 63.16%
kclvm/tools/src/LSP/src/find_refs.rs 2 88.52%
kclvm/sema/src/core/symbol.rs 3 52.54%
kclvm/tools/src/LSP/src/state.rs 4 81.47%
kclvm/parser/src/lib.rs 5 95.59%
kclvm/driver/src/lib.rs 5 81.77%
kclvm/tools/src/LSP/src/util.rs 6 42.95%
Totals Coverage Status
Change from base Build 10575996206: -0.2%
Covered Lines: 50989
Relevant Lines: 72232

💛 - Coveralls

@Peefy Peefy merged commit 67cf599 into kcl-lang:main Aug 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants