-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor find ref and rename #1500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Additional attention should be paid to whether APIs such as Rename, RenamdeCode, and FindRefs, as well as their test cases, have been fully passed without any breaks.
LGTM. Additional attention should be paid to whether APIs such as Rename, RenamdeCode, and FindRefs, as well as their test cases, have been fully passed without any breaks. |
Signed-off-by: he1pa <18012015693@163.com>
dd53318
to
0a100f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Test Coverage Report for Build 10579515428Details
💛 - Coveralls |
blocked by #1510
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
kclvm/sema/src/advanced_resolver/node.rs
kclvm/sema/src/core/symbol.rs
kclvm/tools/src/LSP/src/find_refs.rs
kclvm/tools/src/LSP/src/request.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: