Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance config to schema type check on union expr #1561

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat: enhance config to schema type check on union expr #1561

merged 1 commit into from
Aug 13, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 13, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: enhance config to schema type check on union expr

He1pa
He1pa approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
feat: enhance config to schema type check on union expr
a799a1f 
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the enhance-config-to-schema-ty-check branch from aaada9a to a799a1f Compare August 13, 2024 08:12
@coveralls
Copy link
Collaborator

coveralls commented Aug 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10366074491

Details

  • 48 of 58 (82.76%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 70.538%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/calculation.rs 12 14 85.71%
kclvm/sema/src/resolver/ty.rs 36 44 81.82%
Totals Coverage Status
Change from base Build 10349377096: 0.01%
Covered Lines: 50459
Relevant Lines: 71534
💛 - Coveralls

@Peefy Peefy merged commit 55440ac into kcl-lang:main Aug 13, 2024
12 checks passed
@Peefy Peefy deleted the enhance-config-to-schema-ty-check branch August 13, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Peefy @coveralls @He1pa