feat: add hints for schema config expr

[shruti2522]

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

• N
• Y
  fix [LFX] [Track] LSP inlayhint and hover content content optimization #1244

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

• N
• Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

• Unit test
• Integration test
• Benchmark (add benchmark stats below)
• Manual test (add detailed scripts or steps below)
• Other

[Peefy]

Hello @shruti2522

What I mean in #1575 is to add hints to schema arguments, just like function parameters, rather than schema config expr.

[shruti2522]

How to check for the scope of config expr here? @He1pa @Peefy

[shruti2522]

Hello @shruti2522

What I mean in #1575 is to add hints to schema arguments, just like function parameters, rather than schema config expr.

Okay. I was initially working on adding hints for this, so I misunterstood. Will add hints for schema arguments.

From what I understand it is supposed to be like this? @Peefy @He1pa

schema Name:
    name: str
n: Name = [Name]{  // provide hint of anonymous schema name here
    name: “”
}

[Peefy]

@shruti2522 Examples of schema arguments

schema Person[age: int, name: str]:
    a = age
    n = name

p = Person([age: ]1, [name: ]"Alice") # Add hints here

[Peefy]

Of course, adding hints to the schema config expr is also possible. You can open a new issue and associate it with it.

[He1pa]

Hello @shruti2522
What I mean in #1575 is to add hints to schema arguments, just like function parameters, rather than schema config expr.

Okay. I was initially working on adding hints for this, so I misunterstood. Will add hints for schema arguments.

From what I understand it is supposed to be like this? @Peefy @He1pa

schema Name:
    name: str
n: Name = [Name]{  // provide hint of anonymous schema name here
    name: “”
}

These are two features. Do not associate this PR with #1575, but #1244.

[shruti2522]

currently, hints are also added to schema config where schema name is alraedy defined, for example,

Since config_expr doesn't have a schema name field associated with it, how can we add a check for the name declaration here? Should I do a schema_expr check here or maybe check for identifier expr.

cc @He1pa @Peefy

[Peefy]

Since config_expr doesn't have a schema name field associated with it, how can we add a check for the name declaration here? Should I do a schema_expr check here or maybe check for identifier expr.

cc @He1pa

[shruti2522]

hints for anonymous schema expr:

no hints otherwise:

PTAL @Peefy @He1pa

[Peefy]

hints for anonymous schema expr:

no hints otherwise:

PTAL @Peefy @He1pa

We need to remove : in Name :

[coveralls]

Pull Request Test Coverage Report for Build 10597220055

Details

• 60 of 61 (98.36%) changed or added relevant lines in 2 files are covered.
• 5 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.03%) to 70.619%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kclvm/sema/src/advanced_resolver/node.rs	53	54	98.15%

Files with Coverage Reduction	New Missed Lines	%
kclvm/sema/src/advanced_resolver/node.rs	1	83.6%
kclvm/tools/src/LSP/src/tests.rs	1	98.54%
kclvm/sema/src/core/symbol.rs	3	52.69%

Totals
Change from base Build 10580105310:	0.03%
Covered Lines:	51054
Relevant Lines:	72295

---

💛 - Coveralls

[Peefy]

The complexity of this function is a bit high, and other methods can be used to determine it.

Besides, why add hint only for the assign_stmt

[shruti2522]

I guess hints have to applied only for anonymous schema configs, like

schema Name:
    name: str

n: Name = {
    name = "kcl"
}

that's why I used assign_stmt to determine if type annotations exist for the same, if yes then hints are applied, otherwise not.

[Peefy]

schema Name:
    name: str
    config: Config

schema Config:
    count: int

n: Name = {
    name = "foo"
    config: {
        count: 1
    }
}

The config in the Name schema also needs hints e.g.

schema Name:
    name: str
    config: Config

schema Config:
    count: int

n: Name = [Name ] { # Name schema hints
    name = "foo"
    config: [Config ] { # Config schema hints
        count: 1
    }
}

[shruti2522]

hints are being applied for the config too

[Peefy]

How about this code, an assign stmt with the type annotation and the right value is a schema expr.

schema Name:
    name: str
    config: Config

schema Config:
    count: int

n Name = Name { # Name schema hints
    name = "foo"
    config: [Config ] { # Config schema hints
        count: 1
    }
}

[shruti2522]

I guess we need to add check for schema_expr too

[Peefy]

What I mean is that there are many such grammars, not just checking schema_exp or assign_stmt, but there needs to be a more effective way.

[Peefy]

Hello @shruti2522

Have you been working this issue?

[shruti2522]

Hello @shruti2522

Have you been working this issue?

Yes @Peefy

[Peefy]

Hello @shruti2522

Have you been working this issue and PR? I will close this PR until next week.