Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unification stmt schema arguments parse #1597

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 23, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: unification stmt schema arguments parse

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10522057036

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 70.916%

Totals Coverage Status
Change from base Build 10518946251: 0.004%
Covered Lines: 51568
Relevant Lines: 72717

💛 - Coveralls

@Peefy Peefy merged commit 0b2a81e into kcl-lang:main Aug 23, 2024
12 checks passed
@Peefy Peefy deleted the fix-unification-stmt-schema-args-parse branch August 23, 2024 08:23
shruti2522 pushed a commit to shruti2522/kcl that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants