Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove windows path prefix #1665

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa force-pushed the remove_windows_path_prefix branch from e6df289 to 6ee1cf4 Compare September 29, 2024 02:43
@He1pa He1pa force-pushed the remove_windows_path_prefix branch 2 times, most recently from 63366ef to 8d58c32 Compare October 8, 2024 03:51
@coveralls
Copy link
Collaborator

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11234015808

Details

  • 52 of 62 (83.87%) changed or added relevant lines in 8 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 70.646%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/hover.rs 0 2 0.0%
kclvm/driver/src/lib.rs 20 28 71.43%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/tests.rs 1 98.61%
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
kclvm/sema/src/core/symbol.rs 3 53.63%
kclvm/tools/src/LSP/src/hover.rs 4 89.18%
Totals Coverage Status
Change from base Build 11016636336: 0.01%
Covered Lines: 51438
Relevant Lines: 72811

💛 - Coveralls

@He1pa He1pa force-pushed the remove_windows_path_prefix branch 3 times, most recently from f5d093f to 4ed8857 Compare October 8, 2024 08:53
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the remove_windows_path_prefix branch from 4ed8857 to b4f6da3 Compare October 8, 2024 10:59
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa merged commit 3e84ea4 into kcl-lang:main Oct 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants