Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lambda this closure value and config #1677

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1668

fix: lambda this closure value and config

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11267861683

Details

  • 6 of 54 (11.11%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 70.606%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/context.rs 0 1 0.0%
kclvm/evaluator/src/node.rs 6 9 66.67%
kclvm/evaluator/src/func.rs 0 10 0.0%
kclvm/evaluator/src/lib.rs 0 10 0.0%
kclvm/evaluator/src/rule.rs 0 10 0.0%
kclvm/evaluator/src/schema.rs 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.06%
kclvm/driver/src/toolchain.rs 4 88.89%
Totals Coverage Status
Change from base Build 11247800898: -0.05%
Covered Lines: 51444
Relevant Lines: 72861

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b3a08d3 into kcl-lang:main Oct 10, 2024
13 checks passed
@Peefy Peefy deleted the fix-lambda-this-closure branch October 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] mixin degradation from 0.9 to 0.10
3 participants