Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path canonicalization for parse file API #1708

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 22, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: path canonicalization for parse file API

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 11456255045

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.532%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 3 64.97%
kclvm/tools/src/LSP/src/state.rs 7 81.14%
kclvm/tools/src/LSP/src/dispatcher.rs 7 65.71%
Totals Coverage Status
Change from base Build 11452901582: 0.02%
Covered Lines: 51743
Relevant Lines: 73361

💛 - Coveralls

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the fix-path-canonicalize-for-parse-file-api branch from 170dcef to bb597e7 Compare October 22, 2024 08:27
@Peefy Peefy merged commit fc64537 into kcl-lang:main Oct 22, 2024
13 checks passed
@Peefy Peefy deleted the fix-path-canonicalize-for-parse-file-api branch October 22, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants