Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove duplicate fix_rel_import_path_with_file #1714

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 24, 2024

Parser performance optimization Remove duplicate fix_rel_import_path_with_file

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

…t_path_with_file

Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11494071567

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 42 of 44 (95.45%) changed or added relevant lines in 1 file are covered.
  • 131 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.522%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lib.rs 42 44 95.45%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/tests.rs 2 98.74%
kclvm/parser/src/parser/module.rs 2 93.18%
kclvm/sema/src/resolver/tests.rs 8 98.53%
kclvm/parser/src/lib.rs 16 95.99%
kclvm/ast/src/ast.rs 103 71.61%
Totals Coverage Status
Change from base Build 11492040469: 0.03%
Covered Lines: 51758
Relevant Lines: 73393

💛 - Coveralls

@Peefy Peefy merged commit b99953a into kcl-lang:main Oct 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants