Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ast expr comment format #1720

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: ast expr comment format #1720

merged 1 commit into from
Oct 28, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1719

fix: ast expr comment format

@Peefy
fix: ast expr comment format
0a4ef41 
Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11520252850

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 70.536%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast_pretty/src/node.rs 27 28 96.43%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
kclvm/tools/src/LSP/src/state.rs 12 82.73%
Totals Coverage Status
Change from base Build 11514815168: -0.002%
Covered Lines: 51784
Relevant Lines: 73415
💛 - Coveralls

He1pa
He1pa approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit 5009d06 into kcl-lang:main Oct 28, 2024
13 checks passed
@Peefy Peefy deleted the fix-ast-expr-format branch October 28, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected kcl fmt behaviour (kcl 0.10.5+)
3 participants
@Peefy @coveralls @He1pa