Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp hint for config entry key type #1751

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat: lsp hint for config entry key type #1751

merged 2 commits into from
Nov 14, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 13, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs
kclvm/tools/src/LSP/src/inlay_hints.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added the lsp label Nov 13, 2024
@Peefy
Copy link
Contributor

Peefy commented Nov 13, 2024

Have you tested this feature in konfig repo?

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the feat_attr_type_hint branch from 4a2b360 to b45e7a4 Compare November 13, 2024 11:00
@He1pa
Copy link
Contributor Author

He1pa commented Nov 13, 2024

Have you tested this feature in konfig repo?

image

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Nov 13, 2024

Windows CI failed.

@coveralls
Copy link
Collaborator

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11815888345

Details

  • 40 of 43 (93.02%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.718%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/inlay_hints.rs 22 23 95.65%
kclvm/sema/src/advanced_resolver/node.rs 18 20 90.0%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.13%
kclvm/tools/src/LSP/src/inlay_hints.rs 1 97.96%
kclvm/tools/src/LSP/src/request.rs 2 65.78%
kclvm/sema/src/core/symbol.rs 3 53.43%
Totals Coverage Status
Change from base Build 11813563951: 0.03%
Covered Lines: 52570
Relevant Lines: 74338

💛 - Coveralls

@He1pa He1pa merged commit 96d2731 into main Nov 14, 2024
13 checks passed
@Peefy Peefy deleted the feat_attr_type_hint branch November 14, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants