Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api to get all schema under path #1754

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

add api to get all schema under path

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11834819270

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 54 (22.22%) changed or added relevant lines in 5 files are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.713%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/mod.rs 6 7 85.71%
kclvm/query/src/query.rs 1 42 2.38%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 66.58%
kclvm/sema/src/advanced_resolver/node.rs 1 84.94%
kclvm/parser/src/lib.rs 1 92.97%
kclvm/tools/src/LSP/src/compile.rs 1 80.17%
kclvm/query/src/query.rs 3 25.38%
kclvm/tools/src/LSP/src/dispatcher.rs 11 69.05%
Totals Coverage Status
Change from base Build 11832149998: -0.02%
Covered Lines: 52598
Relevant Lines: 74382

💛 - Coveralls

@Peefy Peefy merged commit 0d34de4 into main Nov 14, 2024
12 of 13 checks passed
@Peefy Peefy deleted the get_full_schema_type_under_path branch November 14, 2024 14:22
SkySingh04 pushed a commit to SkySingh04/kcl that referenced this pull request Dec 24, 2024
feat: add new api to get all schema under path

Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants