Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter expression return type. #546

Merged
merged 1 commit into from
May 12, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 12, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: filter expression return type.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/quant/filter/simple_list_2/main.k

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label May 12, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone May 12, 2023
@Peefy Peefy requested review from NeverRaR, He1pa and zong-zhe May 12, 2023 07:26
@Peefy Peefy self-assigned this May 12, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4956319764

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.2%) to 67.79%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 4922206549: -20.2%
Covered Lines: 30485
Relevant Lines: 44970

💛 - Coveralls

@Peefy Peefy merged commit 74b1794 into kcl-lang:main May 12, 2023
@Peefy Peefy deleted the fix-filter-expr-ret-ty branch May 12, 2023 07:50
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants