Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: parser primary expr loc, ast pretty printer and add more tests #558

Merged
merged 1 commit into from
May 24, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 24, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: parser primary expr loc, ast pretty printer and add more tests

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/ast_pretty/src/node.rs
  • kclvm/parser/src/parser/expr.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

refactor: parser primary expr loc, ast pretty printer and add more tests

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/ast_pretty/src/test_data/**
  • kclvm/parser/src/tests/snapshots/**

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added parser Issues or PRs related to kcl parser ast_prettey labels May 24, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone May 24, 2023
@Peefy Peefy requested review from He1pa and zong-zhe May 24, 2023 05:08
@Peefy Peefy self-assigned this May 24, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5064914842

  • 62 of 65 (95.38%) changed or added relevant lines in 5 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.0%) to 68.036%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/parser/expr.rs 13 14 92.86%
kclvm/parser/src/parser/module.rs 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5042983916: -20.0%
Covered Lines: 30827
Relevant Lines: 45310

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit 7d26909 into kcl-lang:main May 24, 2023
@Peefy Peefy deleted the refactor-parser-printer-loc branch May 24, 2023 06:32
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ast_prettey parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants