Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When checking for changes to the cache, check for external packages. #574

Merged
merged 3 commits into from
Jun 15, 2023
Merged

fix: When checking for changes to the cache, check for external packages. #574

merged 3 commits into from
Jun 15, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix issue #573

2. What is the scope of this PR (e.g. component or file name):

kclvm-config

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

When checking for changes to the cache, check for external packages.

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added the bug Something isn't working label Jun 15, 2023
@zong-zhe zong-zhe added this to the v0.5.0 Release milestone Jun 15, 2023
@zong-zhe zong-zhe self-assigned this Jun 15, 2023
kclvm/config/src/cache.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5278695998

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5210392291: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 15, 2023

Pull Request Test Coverage Report for Build 5278696000

  • 82 of 83 (98.8%) changed or added relevant lines in 6 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.9%) to 68.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/utils/src/pkgpath.rs 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5210392291: -19.9%
Covered Lines: 30923
Relevant Lines: 45401

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 8bb66cf into kcl-lang:main Jun 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants