Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime literal union type check. #600

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 10, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #594

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/val_type.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/literal/lit_07_uf8_str_union/main.k

@Peefy Peefy added the runtime Issues or PRs related to kcl runtime including value and value opertions label Jul 10, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone Jul 10, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2023

Pull Request Test Coverage Report for Build 5508059429

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.9%) to 68.065%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5507363291: -19.9%
Covered Lines: 30935
Relevant Lines: 45449

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 64c6136 into kcl-lang:main Jul 10, 2023
@Peefy Peefy deleted the fix-runtime-union-ty-check branch July 10, 2023 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid runtime union type check that contains utf-8 chars
3 participants