Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl include schema type path for planned values including JSON and YAML. #659

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 14, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #654

feat: impl include schema type path for planned values including JSON and YAML.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/val_plan.rs
  • kclvm/runtime/src/api/kclvm.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/capi_test.rs
  • kclvm/api/src/testdata/exec-program-with-include-schema-type-path.json
  • kclvm/api/src/testdata/exec-program-with-include-schema-type-path.response.json

@Peefy Peefy added api Issues or PRs related to kcl rust native APIs and multi-lang APIs runtime Issues or PRs related to kcl runtime including value and value opertions labels Aug 14, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Aug 14, 2023
@Peefy Peefy requested review from amyXia1994, He1pa and zong-zhe August 14, 2023 14:20
@Peefy Peefy self-assigned this Aug 14, 2023
@Peefy Peefy force-pushed the feat-include-schema-type-path branch from 597fe22 to 408c969 Compare August 15, 2023 03:11
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5863183810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5856997191: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@Peefy Peefy force-pushed the feat-include-schema-type-path branch from 408c969 to 627f084 Compare August 15, 2023 04:00
@Peefy Peefy merged commit 1b564db into kcl-lang:main Aug 15, 2023
@Peefy Peefy deleted the feat-include-schema-type-path branch August 15, 2023 05:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCL serialized data supports optional type fields to assist in deserialization
2 participants