Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kubeadm #117

Merged
merged 1 commit into from
Mar 8, 2024
Merged

add kubeadm #117

merged 1 commit into from
Mar 8, 2024

Conversation

liangyuanpeng
Copy link
Contributor

1. Please confirm that you have read the document before PR submitted

2. Contact Information(Optional)

If it is convenient, please provide your contact information so we can reach you when processing the PR:

  • Email:
  • HomePage:

Add kubeadm mode. and this is the first PR, so this is not a complete module.

Copy link

github-actions bot commented Mar 8, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

kubeadm/1.29/kcl.mod Outdated Show resolved Hide resolved
@Peefy
Copy link
Contributor

Peefy commented Mar 8, 2024

Hello @liangyuanpeng, Community thanks for your contribution. Please sign the CLA and DCO to pass CI.

@liangyuanpeng
Copy link
Contributor Author

Please sign the CLA and DCO to pass CI.

no worries, I will do it after the PR is ready

@Peefy BTW,in order to be visible in artifacthub, do I need to manually create artifacthub-pkg.yaml at https://github.com/kcl-lang/modules/tree/main/.integration/artifacthub? It seems that the documentation is https://github.com/kcl- lang/modules?tab=readme-ov-file#prepare-your-kcl-module is outdate.

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Mar 8, 2024

For the CLA, should we use https://github.com/cncf/cla ?

@Peefy
Copy link
Contributor

Peefy commented Mar 8, 2024

BTW,in order to be visible in artifacthub, do I need to manually create artifacthub-pkg.yaml

No, CI will automatically generate the files required for the artifact hub.

@Peefy
Copy link
Contributor

Peefy commented Mar 8, 2024

It seems that the documentation is https://github.com/kcl-lang/modules?tab=readme-ov-file#prepare-your-kcl-module is outdate.

ping @zong-zhe

@zong-zhe
Copy link
Collaborator

zong-zhe commented Mar 8, 2024

It seems that the documentation is https://github.com/kcl- lang/modules?tab=readme-ov-file#prepare-your-kcl-module is outdate.

Hi @liangyuanpeng, I noted in the documentation that this file is optional, if you manually add this file, it will be the file you use, in general you do not need to manually create the file, the file will be automatically generated.

Our strategy is that if there is a configuration file named artifacthub-pkg.yaml in the directory where your module's kcl.mod file is located, then we will use the artifacthub-pkg.yaml you provided to display the information of your module, otherwise, we will use some default information to generate the corresponding artifacthub-pkg.yaml file.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@liangyuanpeng liangyuanpeng changed the title [WIP] add kubeadm add kubeadm Mar 8, 2024
Peefy added a commit to kcl-lang/cla.db that referenced this pull request Mar 8, 2024
@liangyuanpeng
Copy link
Contributor Author

/hold

Let me generate mod file with kcl

@liangyuanpeng
Copy link
Contributor Author

/unhold

kcl mod init have not param of version.

@Peefy Peefy merged commit 9709236 into kcl-lang:main Mar 8, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
@Peefy
Copy link
Contributor

Peefy commented Mar 8, 2024

CI failed when push this module to docker.io with the invalid tag. https://github.com/kcl-lang/modules/actions/runs/8200198425/job/22426514617

@kcl-lang kcl-lang unlocked this conversation Mar 8, 2024
@liangyuanpeng liangyuanpeng deleted the kubeadm_0 branch March 12, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants