Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crd_to_kcl.sh to work with latest kcl import structure #202

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

kukacz
Copy link
Contributor

@kukacz kukacz commented Aug 2, 2024

This change aligns the crd_to_kcl.sh script to work correctly after recent changes in kcl import and
adds a small improvement in source package version handling:

  • Part handling the API version detection and organizing imported files into appropriate subdirectories was removed as this is now directly handled by kcl import.
  • Optional command line argument "version-tag" was added, allowing to specify version tag used by the source repository. This version is automatically added into kcl.mod as version of KCL package.
  • The script drops incoming schema versions identified as "unknown", since those can't be reliably executed. Kindly verify this proposal during review process.

1. Please confirm that you have read the document before PR submitted

2. Contact Information(Optional)

If it is convenient, please provide your contact information so we can reach you when processing the PR:

Email: kukacz@github
HomePage: https://github.com/kukacz

@kukacz kukacz force-pushed the custom-crd-script branch from a2ae436 to da6e534 Compare August 2, 2024 13:33
@kukacz kukacz marked this pull request as ready for review August 2, 2024 13:33
@Peefy
Copy link
Contributor

Peefy commented Aug 2, 2024

Thank you!

@Peefy Peefy merged commit 9c5c551 into kcl-lang:main Aug 2, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants