Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model of karmada #48

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add model of karmada #48

merged 1 commit into from
Nov 7, 2023

Conversation

liangyuanpeng
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Add model of karmada, and provide crds of policy first.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Lan Liang <gcslyp@gmail.com>
Copy link
Contributor Author

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, i have some question at comment for add a new model.

And i have not see the any test for models of this repo.

Remind me if i missed something,Thanks.

karmada/0.1.0/artifacthub-pkg.yaml Show resolved Hide resolved
karmada/kcl.mod Show resolved Hide resolved
@Peefy
Copy link
Contributor

Peefy commented Nov 7, 2023

Actually, i have some question at comment for add a new model.

And i have not see the any test for models of this repo.

Remind me if i missed something,Thanks.

We are currently refactoring the testing tool, which is expected to be available in the official version of v0.7.0. At that time, we will improve the process of writing test cases and test cases (expected to write unit tests like Go). cc @amyXia1994

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution ❤️. I have left some comments.

karmada/kcl.mod Show resolved Hide resolved
karmada/0.1.0/artifacthub-pkg.yaml Show resolved Hide resolved
@Peefy Peefy merged commit 9e5bba5 into kcl-lang:main Nov 7, 2023
1 check passed
@liangyuanpeng liangyuanpeng deleted the karmada branch November 8, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants