Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "KCL: Restart Language Server" command to restart the KCL language server #43

Merged
merged 1 commit into from
May 3, 2024

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Apr 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • [✅ ] Y

Fix #38

2. What is the scope of this PR (e.g. component or file name):

src/extension.ts
package.json

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • [✅ ] Affects user behaviors

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [ ✅ ] N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

No

Copy link

github-actions bot commented Apr 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Gmin2
Copy link
Contributor Author

Gmin2 commented Apr 11, 2024

I have read the CLA Document and I hereby sign the CLA

@Peefy
Copy link
Contributor

Peefy commented Apr 12, 2024

I've added some comments. @He1pa Can you help review it?

@Gmin2
Copy link
Contributor Author

Gmin2 commented May 3, 2024

I've added some comments. @He1pa Can you help review it?

Any updates @Peefy apart from the formating part

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0470b39 into kcl-lang:main May 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add the command to restart the KCL language server
2 participants