Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 migrate to kcp prow #72

Merged
merged 2 commits into from
Jun 12, 2023
Merged

🌱 migrate to kcp prow #72

merged 2 commits into from
Jun 12, 2023

Conversation

palnabarun
Copy link
Member

Summary

Migrate to kcp-prow

Related issue(s)

Fixes kcp-dev/infra#27

/assign @xrstf

@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 26, 2023
@openshift-ci openshift-ci bot requested review from stevekuznetsov and sttts May 26, 2023 10:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevekuznetsov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 26, 2023
@kcp-ci-bot
Copy link
Contributor

Hi @palnabarun. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

Hi @palnabarun. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2023
@xrstf
Copy link
Contributor

xrstf commented May 31, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@palnabarun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/boilerplate 5700a81 link true /test boilerplate
ci/prow/lint 5700a81 link true /test lint
ci/prow/test 5700a81 link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

xrstf
xrstf reviewed Jun 6, 2023
View reviewed changes
.prow.yaml Outdated
containers:
# TODO(nabarun): Change the following to the kcp-dev/build image once it is available
# Ref: https://github.com/kcp-dev/infra/pull/34
- image: quay.io/kubermatic/build:go-1.20-node-18-6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to ghcr.io/kcp-dev/infra/build:1.19.9-2 now :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in https://github.com/palnabarun/kcp-apimachinery/commits/migrate-to-kcp-prow.

There seems to be something wrong with GitHub that this PR is not getting updated with the updated commits. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is updated with the latest commits now. 🎉

palnabarun added 2 commits June 7, 2023 23:44
@palnabarun
add Prow jobs for verify, lint and test
ed4366a 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
remove unused CI operator config
c9b1c4f 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun palnabarun force-pushed the migrate-to-kcp-prow branch from 2f7c7fd to c9b1c4f Compare June 7, 2023 18:20
@palnabarun
Copy link
Member Author

@xrstf all tests are passing now. Can you please have a look?

xrstf
xrstf approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sttts PTAL

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@xrstf
Copy link
Contributor

xrstf commented Jun 9, 2023

/lgtm cancel

@palnabarun Can you also remove the CI Github workflows?

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@kcp-ci-bot kcp-ci-bot requested a review from xrstf June 9, 2023 12:04
@sttts
Copy link
Member

sttts commented Jun 9, 2023

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@xrstf
Copy link
Contributor

xrstf commented Jun 12, 2023

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 744ffda28e758c073ed7ef83614710e082afc1fd

@kcp-ci-bot kcp-ci-bot merged commit 0777f5c into kcp-dev:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@sttts sttts Awaiting requested review from sttts

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate kcp-dev/apimachinery
4 participants
@palnabarun @kcp-ci-bot @xrstf @sttts