-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add .prow.yaml, migrate to kcp-prow #82
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Hi @embik. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
Hi @embik. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @xrstf |
We can also remove the github actions workflows in this PR, right? |
Good question, but I would assume we want to keep validation for e.g. the PR type, so do we want to convert that logic into a prow job? |
I think we can keep it as-is. It uses the one from Kubernetes - https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/.github/actions/verifier/action.yml. Keeping it as-is would make us consistent with upstream 👍 |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/ok-to-test |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
…by prow Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/lgtm |
LGTM label has been added. Git tree hash: da031a2d66296019f0c020cece06e0d9dc8d5bb5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/boilerplate |
@xrstf: Overrode contexts on behalf of xrstf: ci/prow/boilerplate In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@xrstf: Overrode contexts on behalf of xrstf: ci/prow/boilerplate In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/codegen All overridden jobs are part of the new Prow jobs already and since the ci-operator.yaml was removed, there is no chance of these tests succeeding. |
@xrstf: Overrode contexts on behalf of xrstf: ci/prow/codegen, ci/prow/lint, ci/prow/unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@xrstf: Overrode contexts on behalf of xrstf: ci/prow/codegen, ci/prow/lint, ci/prow/unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
This PR moves this repository to the new kcp-prow (also see kcp-dev/infra#25). It uses
ghcr.io/kcp-dev/infra/build:1.19.9-1
, a base image we are building from https://github.com/kcp-dev/infra/tree/main/images/build.Also see openshift/release#39766 for removing this repository from openshift-ci.
Related issue(s)
Fixes kcp-dev/infra#29