Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add .prow.yaml, migrate to kcp-prow #82

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

embik
Copy link
Member

@embik embik commented May 25, 2023

Summary

This PR moves this repository to the new kcp-prow (also see kcp-dev/infra#25). It uses ghcr.io/kcp-dev/infra/build:1.19.9-1, a base image we are building from https://github.com/kcp-dev/infra/tree/main/images/build.

Also see openshift/release#39766 for removing this repository from openshift-ci.

Related issue(s)

Fixes kcp-dev/infra#29

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 25, 2023
@openshift-ci openshift-ci bot requested review from njhale and stevekuznetsov May 25, 2023 16:00
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

Hi @embik. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@kcp-ci-bot
Copy link
Contributor

Hi @embik. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2023
@embik
Copy link
Member Author

embik commented May 25, 2023

/cc @xrstf

@openshift-ci openshift-ci bot requested a review from xrstf May 25, 2023 16:01
@nikhita
Copy link
Member

nikhita commented May 26, 2023

We can also remove the github actions workflows in this PR, right?

@embik
Copy link
Member Author

embik commented May 26, 2023

We can also remove the github actions workflows in this PR, right?

Good question, but I would assume we want to keep validation for e.g. the PR type, so do we want to convert that logic into a prow job?

@nikhita
Copy link
Member

nikhita commented May 27, 2023

Good question, but I would assume we want to keep validation for e.g. the PR type, so do we want to convert that logic into a prow job?

I think we can keep it as-is. It uses the one from Kubernetes - https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/.github/actions/verifier/action.yml.

Keeping it as-is would make us consistent with upstream 👍

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@xrstf
Copy link

xrstf commented May 31, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2023
embik added 2 commits May 31, 2023 12:09
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
…by prow

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@sttts
Copy link
Member

sttts commented Jun 5, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da031a2d66296019f0c020cece06e0d9dc8d5bb5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@xrstf
Copy link

xrstf commented Jun 5, 2023

/override ci/prow/boilerplate

@kcp-ci-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/boilerplate

In response to this:

/override ci/prow/boilerplate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/boilerplate

In response to this:

/override ci/prow/boilerplate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link

xrstf commented Jun 5, 2023

/override ci/prow/codegen
/override ci/prow/lint
/override ci/prow/unit

All overridden jobs are part of the new Prow jobs already and since the ci-operator.yaml was removed, there is no chance of these tests succeeding.

@kcp-ci-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/codegen, ci/prow/lint, ci/prow/unit

In response to this:

/override ci/prow/codegen
/override ci/prow/lint
/override ci/prow/unit

All overridden jobs are part of the new Prow jobs already and since the ci-operator.yaml was removed, there is no chance of these tests succeeding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/codegen, ci/prow/lint, ci/prow/unit

In response to this:

/override ci/prow/codegen
/override ci/prow/lint
/override ci/prow/unit

All overridden jobs are part of the new Prow jobs already and since the ci-operator.yaml was removed, there is no chance of these tests succeeding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot merged commit e20aea2 into kcp-dev:main Jun 5, 2023
@embik embik deleted the prow-migration branch June 5, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate kcp-dev/code-generator
5 participants