Merge pull request #1769 from lionelvillard/fix-defaults-v2

Generate CRD defaults for known types
kcp-dev · Aug 16, 2022 · ae542d1 · ae542d1
2 parents bf26f9c + f46a68d
commit ae542d1
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/pkg/crdpuller/discovery.go b/pkg/crdpuller/discovery.go
@@ -455,6 +455,10 @@ func (sc *SchemaConverter) VisitPrimitive(p *proto.Primitive) {
 	sc.setupDescription(p)
 	sc.schemaProps.Type = p.Type
 	sc.schemaProps.Format = p.Format
+
+	if defaults, ok := knownDefaults[p.Path.String()]; ok {
+		sc.schemaProps.Default = defaults
+	}
 }
 
 func (sc *SchemaConverter) VisitKind(k *proto.Kind) {
@@ -627,3 +631,7 @@ func init() {
 		}
 	}
 }
+
+var knownDefaults map[string]*apiextensionsv1.JSON = map[string]*apiextensionsv1.JSON{
+	"io.k8s.api.core.v1.ContainerPort.protocol": {Raw: []byte(`"TCP"`)},
+}