Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to cmd/test-server and/or cmd/sharded-test-server to deploy the virtual workspaces server standalone #1702

Closed
ncdc opened this issue Aug 8, 2022 · 1 comment · Fixed by #1800
Closed

Add option to cmd/test-server and/or cmd/sharded-test-server to deploy the virtual workspaces server standalone #1702

ncdc opened this issue Aug 8, 2022 · 1 comment · Fixed by #1800
Assignees
@ncdc

Comments

@ncdc
Copy link
Member

ncdc commented Aug 8, 2022

This should be optional, and match the way the Helm chart deploys the virtual workspaces server in a standalone container, e.g.

https://github.com/kcp-dev/helm-charts/blob/d3c0a50c6dc3f61421305156b5c7e93fd83c35db/charts/kcp/templates/kcp.yaml#L205-L206

https://github.com/kcp-dev/helm-charts/blob/d3c0a50c6dc3f61421305156b5c7e93fd83c35db/charts/kcp/templates/kcp.yaml#L283-L304
@ncdc ncdc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 8, 2022
@ncdc ncdc added this to the TBD milestone Aug 8, 2022
@csams csams added this to kcp Aug 8, 2022
@csams csams moved this to New in kcp Aug 8, 2022
@ncdc ncdc mentioned this issue Aug 8, 2022
Closed
@stevekuznetsov
Copy link
Contributor

@sttts and I were talking about this - sounds like we might want three tests in the end:

  • non-sharded e2e for control plane, in-process
  • sharded e2e for control plane, deployed to a k8s cluster (this issue would fit here)
  • e2e for TMC, deployed to k8s

This was referenced Aug 16, 2022
Closed
Merged
@ncdc ncdc self-assigned this Aug 19, 2022
@ncdc ncdc removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 19, 2022
Repository owner moved this from New to Done in kcp Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncdc ncdc

Labels
None yet
Projects
kcp
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sharded-test-server: support standalone vw server ncdc/kcp
2 participants
@ncdc @stevekuznetsov