sharded-test-server: support standalone vw server #1800
Conversation
| @@ -53,9 +60,9 @@ func startFrontProxy(ctx context.Context, args []string, servingCA *crypto.CA, h | |||
| lineprefix.Color(color.New(color.FgHiWhite)), | |||
| ) | |||
|
|
|||
| if err := ioutil.WriteFile(filepath.Join(workDirPath, ".kcp-front-proxy/mapping.yaml"), []byte(` | |||
| if err := ioutil.WriteFile(filepath.Join(workDirPath, ".kcp-front-proxy/mapping.yaml"), []byte(fmt.Sprintf(` | |||
There was a problem hiding this comment.
Since we're now print-formatting some YAML, would it be difficult to define an anonymous type here and marshal it instead?
| commandLine = append( | ||
| commandLine, | ||
| "--kubeconfig=.kcp-0/admin.kubeconfig", | ||
| "--context=system:admin", |
There was a problem hiding this comment.
@s-urbaniak @csams @kylape reminder: we definitely don't want this medium term, but find a way, probably some special RBAC permission to do wildcard list/watch.
Add --context to the standalone virtual-workspaces process to allow specifying the context in the kubeconfig to use. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
When running sharded-test-server, if you now pass --shard-run-virtual-workspaces=false, it will run virtual-workspaces in standalone mode, and configure the front proxy to map to the virtual-workspaces process for /services. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
ncdc
force-pushed
the
e2e/standalone-virtual
branch
from
1555b35 to
32eab91
Compare
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
| ProxyClientCert: ".kcp-front-proxy/requestheader.crt", | ||
| ProxyClientKey: ".kcp-front-proxy/requestheader.key", | ||
| }, | ||
| } |
There was a problem hiding this comment.
for follow-up: we should really turn this mapping file into flags. The file promises flexibility that is not there.
There was a problem hiding this comment.
Is there an issue for that?
|
|
||
| func startVirtual(ctx context.Context, index int, logDirPath string) (<-chan error, error) { | ||
| logger := klog.FromContext(ctx) | ||
| logger.Info("starting virtual-workspaces standalone server", "index", index) |
There was a problem hiding this comment.
nit: not sure we do that elsewhere, but maybe print the command line with all parameters instead?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Summary
When running sharded-test-server, if you now pass --shard-run-virtual-workspaces=false, it will run virtual-workspaces in
standalone mode, and configure the front proxy to map to the virtual-workspaces process for /services.
Note, this does not currently wire anything into CI/e2e tests. Figured we'd want to discuss where to plumb this in.
Related issue(s)
Fixes #1702