Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot watch with wildcards (across logical clusters) if the CRD hasn't been added in the admin logical cluster #183

Closed
davidfestal opened this issue Oct 7, 2021 · 0 comments · Fixed by kcp-dev/kubernetes#15
Closed

Cannot watch with wildcards (across logical clusters) if the CRD hasn't been added in the admin logical cluster #183

davidfestal opened this issue Oct 7, 2021 · 0 comments · Fixed by kcp-dev/kubernetes#15
Assignees
@davidfestal
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@davidfestal
Copy link
Member

Describe the bug

One cannot watch with wildcards (across logical clusters) if the CRD of the related API Resource hasn't been added in the admin logical cluster first.

To Reproduce
Steps to reproduce the behavior:

  1. Run KCP
  2. kubectl --context=user apply -f contrib/crds/apps/apps_deployments.yaml
  3. kubectl --context=user api-resources
    => deployments are in the API Resources list
  4. kubectl --context=user proxy --port=8080 &
  5. curl -v -H "X-Kubernetes-Cluster: user" http://127.0.0.1:8080/apis/apps/v1/deployments/
    => returns {"apiVersion":"apps/v1","items":[],"kind":"DeploymentList","metadata":{"continue":"","resourceVersion":"167"}}
  6. curl -v -H "X-Kubernetes-Cluster: *" http://127.0.0.1:8080/apis/apps/v1/deployments/
    => returns the 404 error

Expected behavior

It should return an empty list as soon as the expected CRD is found in at least one of the logical clusters.
@davidfestal davidfestal added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2021
davidfestal added a commit to davidfestal/kcp-kubernetes that referenced this issue Oct 7, 2021
@davidfestal
HACK: Search for the right CRD cluster when watching...
4495fe7 
This hack:
- fixes  issue kcp-dev/kcp#183
- Implements a minimal support for parent cluster:
the ability to manage a resource instance based on a CRD
found in the parent cluster.
- No default parent (as admin for example), because there are
too many unsupported cases in CRD inheritance implementation:
  - transitive parents,
  - how do we delete instances on an inherited CRD ?,
  - ...

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal self-assigned this Oct 11, 2021
davidfestal added a commit to davidfestal/kcp-kubernetes that referenced this issue Nov 4, 2021
@davidfestal
HACK: Search for the right CRD cluster when watching...
3932fc7 
This hack fixes issue kcp-dev/kcp#183: One cannot
watch with wildcards (across logical clusters) if the CRD of the related API Resource
hasn't been added in the admin logical cluster first.

The fix in this HACK is limited since the request will fail if 2 logical clusters
contain CRDs for the same GVK with non-equal specs (especially non-equal schemas).

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal mentioned this issue Nov 4, 2021
Merged
ncdc pushed a commit to ncdc/kubernetes that referenced this issue Dec 16, 2021
@davidfestal @ncdc
HACK: Search for the right CRD cluster when watching...
19b3bf5 
This hack fixes issue kcp-dev/kcp#183: One cannot
watch with wildcards (across logical clusters) if the CRD of the related API Resource
hasn't been added in the admin logical cluster first.

The fix in this HACK is limited since the request will fail if 2 logical clusters
contain CRDs for the same GVK with non-equal specs (especially non-equal schemas).

Signed-off-by: David Festal <dfestal@redhat.com>
ncdc pushed a commit to ncdc/kubernetes that referenced this issue Feb 3, 2022
@davidfestal @ncdc
HACK: Search for the right CRD cluster when watching...
6c8577c 
This hack fixes issue kcp-dev/kcp#183: One cannot
watch with wildcards (across logical clusters) if the CRD of the related API Resource
hasn't been added in the admin logical cluster first.

The fix in this HACK is limited since the request will fail if 2 logical clusters
contain CRDs for the same GVK with non-equal specs (especially non-equal schemas).

Signed-off-by: David Festal <dfestal@redhat.com>
stevekuznetsov pushed a commit to stevekuznetsov/kubernetes that referenced this issue Jul 11, 2022
@davidfestal @stevekuznetsov
HACK: Search for the right CRD cluster when watching...
47f4d2a 
This hack fixes issue kcp-dev/kcp#183: One cannot
watch with wildcards (across logical clusters) if the CRD of the related API Resource
hasn't been added in the admin logical cluster first.

The fix in this HACK is limited since the request will fail if 2 logical clusters
contain CRDs for the same GVK with non-equal specs (especially non-equal schemas).

Signed-off-by: David Festal <dfestal@redhat.com>
stevekuznetsov pushed a commit to stevekuznetsov/kubernetes that referenced this issue Jul 13, 2022
@davidfestal @stevekuznetsov
HACK: Search for the right CRD cluster when watching...
792c197 
This hack fixes issue kcp-dev/kcp#183: One cannot
watch with wildcards (across logical clusters) if the CRD of the related API Resource
hasn't been added in the admin logical cluster first.

The fix in this HACK is limited since the request will fail if 2 logical clusters
contain CRDs for the same GVK with non-equal specs (especially non-equal schemas).

Signed-off-by: David Festal <dfestal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfestal davidfestal

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HACK: Search for the right CRD cluster when watching with wildcards davidfestal/kcp-kubernetes
1 participant
@davidfestal