Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure Out Correct Way To Separate Codegen Tags and GoDoc #2614

Closed
stevekuznetsov opened this issue Jan 12, 2023 · 5 comments
Closed

Figure Out Correct Way To Separate Codegen Tags and GoDoc #2614

stevekuznetsov opened this issue Jan 12, 2023 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@stevekuznetsov
Copy link
Contributor

    For types where these attributes were *also* added to struct tags, having them on separate lines caused an error:
2023/01/11 07:57:40 OpenAPI code generation error: Failed executing generator: some packages had errors:
Tags in comment and struct should match for member (SubResources) of (github.com/kcp-dev/kcp/pkg/apis/apiresource/v1alpha1.CommonAPIResourceSpec)

Why is it correct to do this here?

Originally posted by @stevekuznetsov in #2105 (comment)

@stevekuznetsov
Copy link
Contributor Author

cc @ncdc

@ncdc ncdc added this to kcp Jan 12, 2023
@github-project-automation github-project-automation bot moved this to New in kcp Jan 12, 2023
@nrb nrb moved this from New to Backlog in kcp Jan 17, 2023
@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
@kcp-ci-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 15, 2024
@kcp-ci-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kcp-ci-bot
Copy link
Contributor

@kcp-ci-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Backlog to Done in kcp Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Done
Development

No branches or pull requests

2 participants