Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 add initial rest patterns doc #1086

Closed
wants to merge 3 commits into from
Closed

📖 add initial rest patterns doc #1086

wants to merge 3 commits into from

Conversation

pweil-
Copy link
Member

@pweil- pweil- commented May 18, 2022

Migration public doc (courtesy of @ncdc) https://docs.google.com/document/d/1KbOk-17cvp92GGNO_rXnl-xjY2-ABECkjdEIMU5t6_A/edit#heading=h.wa89p31bvup4 to repo doc with the omission of the wildcard patterns section which is marked as in-progress and to be ignored.


### Normal CRD (current)

`/registry/$group/$resource/$cluster/[$namespace]/$name`
Copy link
Member

@sttts sttts May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been replaced by the second afaik. @ncdc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the RBAC look like for the virtual workspaces? is it a nonResourceURL?

@sttts
Copy link
Member

sttts commented May 26, 2022

What does the RBAC look like for the virtual workspaces? is it a nonResourceURL?

To be implemented by vw. That's the value proposition basically: in vw we can apply any custom authorization. See Slack, pointed you to one of the tasks.


## Cluster Resources and APIs

### `/clusters/$cluster/apis/$group/$version/$resource`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need another case of identity: /clusters/*/apis/$group/$version/$resource+$identity. @ncdc is that correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pweil-
Copy link
Member Author

pweil- commented Jun 9, 2022

I'll address the comments on this tomorrow. Been a bit swamped, sorry on the delay.

Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pweil-
To complete the pull request process, please assign stevekuznetsov after the PR has been reviewed.
You can assign the PR to them by writing /assign @stevekuznetsov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pweil-
Copy link
Member Author

pweil- commented Jun 10, 2022

@ncdc if you want to review the remaining open items that you were tagged in I'll update as necessary. Thanks for the reviews so far.

@ncdc ncdc changed the title add initial rest patterns doc 📖 add initial rest patterns doc Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2022

@pweil-: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-sharded 76abfe3 link true /test e2e-sharded

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc
Copy link
Member

ncdc commented Mar 6, 2023

Replaced by #2867

@ncdc ncdc closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants