-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 add initial rest patterns doc #1086
Conversation
|
||
### Normal CRD (current) | ||
|
||
`/registry/$group/$resource/$cluster/[$namespace]/$name` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been replaced by the second afaik. @ncdc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the RBAC look like for the virtual workspaces? is it a nonResourceURL?
To be implemented by vw. That's the value proposition basically: in vw we can apply any custom authorization. See Slack, pointed you to one of the tasks. |
|
||
## Cluster Resources and APIs | ||
|
||
### `/clusters/$cluster/apis/$group/$version/$resource` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need another case of identity: /clusters/*/apis/$group/$version/$resource+$identity
. @ncdc is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll address the comments on this tomorrow. Been a bit swamped, sorry on the delay. |
Co-authored-by: Tim Bannister <tim@scalefactory.com> Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pweil- The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ncdc if you want to review the remaining open items that you were tagged in I'll update as necessary. Thanks for the reviews so far. |
@pweil-: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Replaced by #2867 |
Migration public doc (courtesy of @ncdc) https://docs.google.com/document/d/1KbOk-17cvp92GGNO_rXnl-xjY2-ABECkjdEIMU5t6_A/edit#heading=h.wa89p31bvup4 to repo doc with the omission of the wildcard patterns section which is marked as in-progress and to be ignored.