adding authorizer for the api export virtual workspace #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
add-authorizer-vw-apiexport
branch
from
336946a to
29481ac
Compare
shawn-hurley
force-pushed
the
add-authorizer-vw-apiexport
branch
from
29481ac to
a519e23
Compare
shawn-hurley
force-pushed
the
add-authorizer-vw-apiexport
branch
from
a519e23 to
2907e32
Compare
sttts
reviewed
Jun 3, 2022
sttts
reviewed
Jun 3, 2022
sttts
reviewed
Jun 3, 2022
sttts
reviewed
Jun 3, 2022
|
Some small comments. |
sttts
reviewed
Jun 3, 2022
shawn-hurley
force-pushed
the
add-authorizer-vw-apiexport
branch
from
2907e32 to
caf8732
Compare
sttts
approved these changes
Jun 3, 2022
stevekuznetsov
pushed a commit
to stevekuznetsov/kcp
that referenced
this pull request
Jun 8, 2022
…piexport adding authorizer for the api export virtual workspace Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the authorizer for apiexport that will check that the requesting user has access to the apiexport context subresource for the specific API export. the verb being used will be forwarded along to be checked.
example: watch cowboys
request path:
/services/apiexport/root:org:ws/cowboys-export/clusters/*/api/v1/cowboysSAR check would ask if I can
liston the specificcowboys-export/contentsubresource.Related issue(s)
Follow on for: #1176
Fixes #1151