Add authorizers in virtual workspaces #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
authorizers-in-virtual-workspaces
branch
from
a55eed7 to
66cc1dc
Compare
shawn-hurley
approved these changes
Jun 1, 2022
| if vw.Authorizer != nil { | ||
| return vw.Authorizer(ctx, a) | ||
| } | ||
| return authorizer.DecisionAllow, "", nil |
There was a problem hiding this comment.
So to avoid breaking anything we'd add an explicit AllowEverything authorizers in all the virtual workspace instances ?
There was a problem hiding this comment.
At least to make it clear that there's still work to be done ?
There was a problem hiding this comment.
we can break non-authorized tests (and ppl working without today). That's totally fine.
There was a problem hiding this comment.
Also a vw without authorizer should forbid every request.
... when no autorizer is defined. Signed-off-by: David Festal <dfestal@redhat.com>
sttts
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add authorizers in virtual workspaces
Related issue(s)
This is a pre-requisite for issues #1172 and #1151