pkg/authorization: don't check for cluster workspace lister. #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently checking for initialize permissions on the parent cluster relies nil-checking the cluster workspace lister. This worked under the assumption that clusterworkspace CRDs are being installed in the workspace controller/scheduler. This does not hold true any more. Clusterworkspace CRDs are now initialized as part of the server bootstrap, independent of the workspace controller/scheduler, hence these CRDs are always available. Even if we omit bootstrapping those CRDs the value will not be nil (verified in a debugger session). This fixes it.
|
/cc @sttts |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently checking for initialize permissions on the parent cluster relies nil-checking the cluster workspace lister.
This worked under the assumption that clusterworkspace CRDs are being installed in the workspace controller/scheduler.
This does not hold true any more. Clusterworkspace CRDs are now initialized as part of the server bootstrap,
independent of the workspace controller/scheduler, hence these CRDs are always available.
Even if we omit bootstrapping those CRDs the value will not be nil (verified in a debugger session).
This fixes it.
Related issue(s)
#425, #422