virtual: Remove unsupported verbs from virtual API server discovery #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
approved these changes
Jun 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-0.5 |
|
@astefanutti: new pull request created: #1275 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
create,deleteanddeletecollectionverbs from the discovery results returned by the virtual API server, as these are not supported by the underlying storage implementation, and leads the virtual API server to panic when the corresponding operations are being requested, and the client requests to be closed abruptly without further details.Support for these operations will be provided in a future PR. In the interim, this PR prevents the virtual API server from panicking, and makes it return "405 Method Not Allowed" to clients, that try to perform these not supported operations.
Related issue(s)
Relates to #1253.