reconciler/workload/resource: remove syncer finalizer when SyncTarget is gone #1293
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
needs-rebase
|
@sttts: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I guess this is related to #1353 that I just filed |
sttts
force-pushed
the
sttts-cleanup-syncer-finalizer
branch
from
f01393e to
9ee92ff
Compare
openshift-ci
bot
removed
the
approved
sttts
changed the title
sttts
force-pushed
the
sttts-cleanup-syncer-finalizer
branch
from
9ee92ff to
c65c674
Compare
| SyncTargetsBySyncTargetKey = "SyncTargetsBySyncTargetKey" | ||
| ) | ||
|
|
||
| func IndexSyncTargetsBySyncTargetKey(obj interface{}) ([]string, error) { |
There was a problem hiding this comment.
@ncdc is our plan to move all indexers here? I think I would like that.
sttts
force-pushed
the
sttts-cleanup-syncer-finalizer
branch
from
c65c674 to
654a4b7
Compare
openshift-ci
bot
added
the
kind/api-change
openshift-merge-robot
removed
the
needs-rebase
sttts
force-pushed
the
sttts-cleanup-syncer-finalizer
branch
from
654a4b7 to
f5d722a
Compare
sttts
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sttts
force-pushed
the
sttts-cleanup-syncer-finalizer
branch
from
f5d722a to
1b6bfe5
Compare
|
/retest |
|
FTR this would be done by the Virtual Workspace in the context of the 1st Syncer Virtual Workspace Transformation PR, which manages the deletion process previously managed by the Syncer, and also the cleanup of related annotations / labels. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
When a SyncTarget is deleted, the syncer loses the ability to remove its finalizer from objects because the VW will not let it see its objects. This PR will make the workload resource controller do this by checking existence of the SyncTargets.
Fixes #1353