Makefile: add test-e2e-shared #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sttts
force-pushed
the
sttts-makefile-shared-test
branch
from
a5f5cfb to
b1dc9b3
Compare
sttts
force-pushed
the
sttts-makefile-shared-test
branch
from
b1dc9b3 to
fad7703
Compare
|
/lgtm |
aojea
reviewed
Jun 20, 2022
| test-e2e-shared: LOG_DIR ?= .kcp | ||
| endif | ||
| test-e2e-shared: build-all | ||
| kind get kubeconfig > "$(PWD)/kind.kubeconfig" |
There was a problem hiding this comment.
does the cluster created with kind use the default name?
otherwise you have to specify the name with the lag kind get kubeconfig --name nameofthecluster
There was a problem hiding this comment.
for now yes. Moving to prow scripting now. Will see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be added to https://github.com/openshift/release/blob/befda62f718d7b84b37a3ed8cc722ec6de51286f/ci-operator/config/kcp-dev/kcp/kcp-dev-kcp-main.yaml.