server/home: create home workspace with final URL on ~ access

[sttts]

Solving this TODO:

// TODO: The way we build this URL here is not fully compatible with sharding long-term:
// - short term (what is done now): use genericConfig.ExternalAddress
// - medium term: shards will know their name eventually, and with that we can lookup the external URL of the shard
// - long-term: create home workspace already on `~` access in order to make scheduling happen and then we know the real external URL.

We need this earlier than we expected. In the sharded setup the ~ workspace has to point to the external URL, not the shard base URL.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sttts]

/cherry-pick release-0.6

[openshift-cherrypick-robot]

@sttts: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[davidfestal]

/lgtm

[davidfestal]

/lgtm

[openshift-cherrypick-robot]

@sttts: #1530 failed to apply on top of branch "release-0.6":

Applying: server/home: simplify unit tests with builder pattern
Applying: server/home: create home workspace with final URL on ~ access
Using index info to reconstruct a base tree...
M	test/e2e/homeworkspaces/home_workspaces_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/homeworkspaces/home_workspaces_test.go
CONFLICT (content): Merge conflict in test/e2e/homeworkspaces/home_workspaces_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 server/home: create home workspace with final URL on ~ access
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.