Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: reduce client-side throttling #1543

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jul 15, 2022

Summary

Disable client-side throttling in our e2e kcp server rest.Configs and in
the cross cluster list test, which uses discovery and is subject to
throttling.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from davidfestal and sttts July 15, 2022 18:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
@stevekuznetsov
Copy link
Contributor

Just the one flake, seems like a reasonable change

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@sttts
Copy link
Member

sttts commented Jul 17, 2022

Local

ARTIFACT_DIR=$PWD/artifacts UNSAFE_E2E_HACK_DISABLE_ETCD_FSYNC=true E2E_PARALLELISM=8 make test-e2e-shared

went from 3:50 min to 2:05min 🎉

@sttts
Copy link
Member

sttts commented Jul 18, 2022

/retest

@sttts
Copy link
Member

sttts commented Jul 20, 2022

needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022
Disable client-side throttling in our e2e kcp server rest.Configs and in
the cross cluster list test, which uses discovery and is subject to
throttling.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022
@sttts
Copy link
Member

sttts commented Jul 20, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@ncdc
Copy link
Member Author

ncdc commented Jul 20, 2022

/test test

@stevekuznetsov
Copy link
Contributor

/retest

@stevekuznetsov
Copy link
Contributor

just merge already jeeezs

@openshift-merge-robot openshift-merge-robot merged commit ab0aa77 into kcp-dev:main Jul 20, 2022
@ncdc ncdc deleted the e2e-speedup branch July 29, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants