sharded-test-server: set shard external URL to front-proxy #1552
Conversation
sttts
force-pushed
the
sttts-front-proxy-external-url
branch
from
1a69a40 to
0745ee5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -76,6 +76,7 @@ func startShard(ctx context.Context, n int, args []string, servingCA *crypto.CA, | |||
| "--service-account-key-file=.kcp/service-account.crt", | |||
| "--service-account-private-key-file=.kcp/service-account.key", | |||
| "--audit-log-path", auditFilePath, | |||
| fmt.Sprintf("--shard-external-url=https://%s:%d", hostIP, 6443), | |||
There was a problem hiding this comment.
okay, this points to the front porxy
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e |
1 similar comment
|
/test e2e |
|
/override ci/prow/e2e This does not touch e2e job. |
|
@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Users with kubectl should keep talking to the front-proxy. The shard external URL is what ends up in
ClusterWorkspace.status.baseURL. This PR wires the front-proxy into the external URL of the shard.