Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add Home, Homebucket, and Homeroot workspace info #1561

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Documentation: Add Home, Homebucket, and Homeroot workspace info #1561

merged 6 commits into from
Jul 26, 2022

Conversation

pweil-
Copy link
Member

@pweil- pweil- commented Jul 19, 2022 •
edited
Loading

@pweil- pweil- added documentation kind/documentation Categorizes issue or PR as related to documentation. labels Jul 19, 2022
@pweil- pweil- requested a review from davidfestal July 19, 2022 11:57
@openshift-ci openshift-ci bot requested review from ncdc and stevekuznetsov July 19, 2022 11:57
ncdc
ncdc reviewed Jul 19, 2022
View reviewed changes
@pweil- pweil- force-pushed the cluster-workspace-update branch from 181b3d7 to 3a4d81e Compare July 19, 2022 13:45
@pweil- pweil- force-pushed the cluster-workspace-update branch from 3a4d81e to 1417aa8 Compare July 19, 2022 13:46
@pweil- pweil- changed the title Add Home, Homebucket, and Homeroot workspace info Documentation: Add Home, Homebucket, and Homeroot workspace info Jul 19, 2022
sttts
sttts reviewed Jul 20, 2022
View reviewed changes
sttts
sttts reviewed Jul 20, 2022
View reviewed changes
@sttts
Copy link
Member

sttts commented Jul 20, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
sttts
sttts reviewed Jul 21, 2022
View reviewed changes
sttts
sttts reviewed Jul 21, 2022
View reviewed changes
sttts
sttts reviewed Jul 21, 2022
View reviewed changes
sttts and others added 2 commits July 21, 2022 10:49
@sttts
Update docs/workspaces.md
822b81a
@sttts
Review suggestions
e4be8e8 
Updates to explaining the concept of user home workspaces

Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@pweil-
Copy link
Member Author

pweil- commented Jul 21, 2022

Suggestions accepted, thanks!

@pweil-
Copy link
Member Author

pweil- commented Jul 21, 2022

@davidfestal assigning you for lgtm

davidfestal
davidfestal approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ! Thanks !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stevekuznetsov
stevekuznetsov reviewed Jul 21, 2022
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jul 21, 2022
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jul 21, 2022
View reviewed changes
docs/workspaces.md Outdated

The user home workspace, if enabled, is logically pre-existing for every user, i.e. the user is given that impression. In reality, the home workspace is created on-demand on access, but this creation is not visible from outside.

Only users of the configured home-creator-groups (default `system:authenticated`) will have a home workspace.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a home-creator-group? How do I set it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfestal need your advice here.

@stevekuznetsov
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@stevekuznetsov stevekuznetsov mentioned this pull request Jul 21, 2022
Closed
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@pweil- pweil- mentioned this pull request Jul 22, 2022
Closed
@pweil- pweil- force-pushed the cluster-workspace-update branch from cf0e561 to b6a6c8c Compare July 22, 2022 09:49
stevekuznetsov
stevekuznetsov reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the home-creator-groups bit - I think we can merge as-is but would like to see some comment on how someone changes home-creator-groups in the future to make that actionable for an admin.

@stevekuznetsov
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@sttts
Copy link
Member

sttts commented Jul 26, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@sttts
Copy link
Member

sttts commented Jul 26, 2022

/override ci/prow/e2e-multiple-runs

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e-multiple-runs

In response to this:

/override ci/prow/e2e-multiple-runs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7eaea90 into kcp-dev:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@sttts sttts sttts left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@davidfestal davidfestal davidfestal approved these changes

Assignees

@davidfestal davidfestal

@sttts sttts

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pweil- @sttts @stevekuznetsov @ncdc @davidfestal @openshift-merge-robot