add exports to synctarget API for location workspace #1571
Conversation
Signed-off-by: Jian Qiu <jqiu@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
|
||
| // Versions is the versions of the resource. | ||
| // +optional | ||
| Versions []string `json:"versions"` |
There was a problem hiding this comment.
Do we know what this actually means? Does it mean this list is ordered, and the syncer should take the first version available on the cluster and use that for syncing?
Please update go doc.
There was a problem hiding this comment.
change to Version string, I think we need to get state for each GVR from syncer.
There was a problem hiding this comment.
but we have this problem of skew. Old kube might only have beta version of some API, newer kube has v1 and beta. Newest kube has only v1. We need a plan here how to cope with that. cc @davidfestal
There was a problem hiding this comment.
and this poses the question who will do the conversion.
Side-note: @ncdc, @stevekuznetsov and I talked about CEL conversions yesterday for APIResourceSchemas. Video in slack.
There was a problem hiding this comment.
Proposal:
// versions are the resource versions the syncer can choose to sync depending on
// availability on the downstream cluster. Conversion to the storage version, if necessary,
// will be done on the kcp side. The versions are ordered according by precedence, i.e. the
// first version is preferred.
//
// +kubebuilder .... MinItems=1
// +required
Versions []string `json:"versions"`
Signed-off-by: Jian Qiu <jqiu@redhat.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
qiujian16
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
| // If it is not set, the kubernetes export in the same workspace will be used by default. | ||
| SupportedAPIExports []apisv1alpha1.ExportReference `json:"supportedAPIExports,omitempty"` | ||
|
|
||
| // Cells represent a set of various cell a sync target belongs to. Each cell has a unique type and ID. SyncTargets |
There was a problem hiding this comment.
| // Cells represent a set of various cell a sync target belongs to. Each cell has a unique type and ID. SyncTargets | |
| // Cells represent a set of various cells a sync target belongs to. Each cell has a unique type and ID. SyncTargets |
| SupportedAPIExports []apisv1alpha1.ExportReference `json:"supportedAPIExports,omitempty"` | ||
|
|
||
| // Cells represent a set of various cell a sync target belongs to. Each cell has a unique type and ID. SyncTargets | ||
| // in the same cell runs as they are in the same physical cluster in a certain apsect. i.e. if SyncTargets are in |
There was a problem hiding this comment.
| // in the same cell runs as they are in the same physical cluster in a certain apsect. i.e. if SyncTargets are in | |
| // in the same set of cells runs as they are in the same physical cluster in a certain apsect. i.e. if SyncTargets are in |
| // Cells represent a set of various cell a sync target belongs to. Each cell has a unique type and ID. SyncTargets | ||
| // in the same cell runs as they are in the same physical cluster in a certain apsect. i.e. if SyncTargets are in | ||
| // a network type cell with the same ID, the workloads on these SyncTargets can connect to each other just like in | ||
| // one physical cluster. Cells should be added and updated by different cell provider (i.e. a network provider) |
There was a problem hiding this comment.
| // one physical cluster. Cells should be added and updated by different cell provider (i.e. a network provider) | |
| // one physical cluster. Cells should be added and updated by different cell providers (i.e. a network provider) |
| // in the same cell runs as they are in the same physical cluster in a certain apsect. i.e. if SyncTargets are in | ||
| // a network type cell with the same ID, the workloads on these SyncTargets can connect to each other just like in | ||
| // one physical cluster. Cells should be added and updated by different cell provider (i.e. a network provider) | ||
| Cells []Cell `json:"cells,omitempty"` |
There was a problem hiding this comment.
list-type is map, with type as the key
qiujian16
force-pushed
the
location-workspace-1
branch
3 times, most recently
from
33f91fd to
071d364
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
location-workspace-1
branch
from
071d364 to
fde588e
Compare
qiujian16
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
Related issue(s)
Fixes #